BannerCallout: VR Implementation Changes #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rlingineni
reviewed
Oct 16, 2024
| color={backgroundColor} | ||
| dangerouslySetInlineStyle={{ __style: largePadding }} | ||
| display="none" | ||
| lgDisplay="block" |
There was a problem hiding this comment.
Is this the only thing that's changing? This seems like a lot of dupe
Can we move into a function or something called getResponsiveSize(size:'sm|'lg|'md')
There was a problem hiding this comment.
I'm not sure, but also this approach may have React do 3X the work because the components would still be loaded into the virtual dom I think - since it's hidden by CSS. I think ideally this could be 3 separate smaller components, or abstracted at a different level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BannerCallout: VR Implementation Changes
FIGMA